QR-code component

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  In order to fix the accessibility issues:

  • You need to replace <div class="container"> with the <main class="container"> tag and <div class="attribution"> with the <footer class="attribution">. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you should use one <h1> element in the <main> tag. You can replace your <h2 class="heading-secondary u-small-margin-bottom">Improve your front-end skills by building projects</h2> element with the <h1 class="heading-secondary u-small-margin-bottom">Improve your front-end skills by building projects</h1> element.

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  Hope I am helpful. :)

  Marked as helpful

  1

  ---

  

  Musread•130

  @MusreadPosted over 1 year ago

  @ecemgo This is very helpful ! Thank you a lot for theses informations 🙂

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @Musread I'm happy to help :)

  0
• 

  Bader Idris•2,880

  @Bader-IdrisPosted over 1 year ago

  You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

  .container {
    display: absolute;
    top:50%;
    left: 50%;
    transform: translate(-50%, -50%);
  }
  

  the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

  Marked as helpful

  0

  ---

  

  Musread•130

  @MusreadPosted over 1 year ago

  @Bader-Idris Oh I should have though about this solution ! Thank you for the tip 👍 !

  0