QR-code challenge

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • In order to fix the accessibility issues, you need to replace <div class="container"> with the <main> tag and <div class="attribution"> with the <footer> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

  • Also, each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you need to use a <h1> element in the <main> tag instead of using <h3>. You can replace your <h3>Improve your front-end skills by building projects</h3> elements with the <h1>Improve your front-end skills by building projects</h1> element.

  Hope I am helpful. :)

  Marked as helpful

  0

  ---

  

  projectgreenhat•20

  @projectgreenhatPosted over 1 year ago

  @ecemgo Thankx! Right after this challenge i read about the html semantics. haha Pls keep guiding me for my future challenges as well.

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @projectgreenhat I'm happy to help and glad that you've read HTML Semantics. If I come across your work, I would like to give feedback. Even if I am not, there are already other friends who want to help. Happy coding! :)

  0