QR-Card-Design

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • In order to center the card correctly, you'd better add min-height: 100vh to the body
  • For the color of the screen, you can use the recommended color in the body

  body {
    /* background: #bcc7eb; */
    /* width: 100%; */
    /* height: 100vh; */
    min-height: 100vh;
    background-color: hsl(212, 45%, 89%);
  }
  

  • If you use flexbox in the body, you don't need to use flexbox in the .container to center the card
  • If you use max-width instead of width, the card will be responsive.

  .container {
    /* background: #e6f0ff; */
    background: white;
    padding: 15px;
    border-radius: 10px;
    /* width: 350px; */
    max-width: 350px;
    /* display: flex; */
    /* justify-content: center; */
    /* align-items: center; */
    /* flex-direction: column; */
  }
  

  • In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better add width: 100% and display: block for the img in this way:

  .card-img img {
    border-radius: 10px;
    /* margin-bottom: 22px; */
    width: 100%;
    display: block;
  }
  

  • Finally, you can add these styles to the h2

  h2 {
    margin: 30px 0;
    text-align: center;
  }
  

  Hope I am helpful. :)

  Marked as helpful

  3

  ---

  

  Rudy Alexander Perez De La Cruz•20

  @rudyalexanderperezdelacruzPosted over 1 year ago

  thanks @ecemgo

  1
• 

  Bader Idris•2,880

  @Bader-IdrisPosted over 1 year ago

  You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

  .container {
    position: absolute;
    top:50%;
    left: 50%;
    transform: translate(-50%, -50%);
  }
  

  the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

  Marked as helpful

  1

  ---

  

  Rudy Alexander Perez De La Cruz•20

  @rudyalexanderperezdelacruzPosted over 1 year ago

  thank u@Bader-Idris

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0