QR Code Practice

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted about 1 month ago

  Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

  • Overusing <div> tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like <header>, <section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.

  			<div class="container-img">
  				<img src="./images/image-qr-code.png" alt="qr-code" />
  			</div>
  

  • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

  • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

  • Setting font-size: 62.5% can affect accessibility by reducing the default browser font size, potentially making text harder to read for users with visual impairments. This does make it easier to work out the relative units but at what cost?

  • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

  I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

  Marked as helpful

  1

  ---

  

  Ruben•40

  @RuxCastilloPosted about 1 month ago

  @Stroudy Thank you very much for all the feedback, I really appreciate it, I realized several things that I didn't know, I'm already uploading the next challenge and I consider improving several things that you told me.

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted about 1 month ago

  Hey @RuxCastillo, You got this! 💪

  1
• 

  P

  Christopher Santos Stieler•10

  @christopherstielerPosted about 1 month ago

  This is amazinig solution to scan QR code. The semantic is perfect, nice work! Thanks for the inspiration!

  1

  ---

  

  Ruben•40

  @RuxCastilloPosted about 1 month ago

  @christopherstieler Hi Christopher, thank you very much for the words and for taking the time to comment, I really liked it.

  0