Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Practice

Ruben 40

@RuxCastillo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I liked that it was a simple test that allowed me to learn how design files work and understand how practical it is to have one of these, instead of trying to design one myself.

What challenges did you encounter, and how did you overcome them?

I encountered the challenge that it did not work when I set the object-fit property, I learned that you have to set width and height for this to work.

What specific areas of your project would you like help with?

If possible, a general review of how I could have done the CSS better

Community feedback

P
Steven Stroud 11,810

@Stroudy

Posted

Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

  • Overusing <div> tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like <header>, <section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.
			<div class="container-img">
				<img src="./images/image-qr-code.png" alt="qr-code" />
			</div>
  • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

  • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

  • Setting font-size: 62.5% can affect accessibility by reducing the default browser font size, potentially making text harder to read for users with visual impairments. This does make it easier to work out the relative units but at what cost?

  • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

Marked as helpful

1

Ruben 40

@RuxCastillo

Posted

@Stroudy Thank you very much for all the feedback, I really appreciate it, I realized several things that I didn't know, I'm already uploading the next challenge and I consider improving several things that you told me.

1
P
Steven Stroud 11,810

@Stroudy

Posted

Hey @RuxCastillo, You got this! 💪

1
P

@christopherstieler

Posted

This is amazinig solution to scan QR code. The semantic is perfect, nice work! Thanks for the inspiration!

1

Ruben 40

@RuxCastillo

Posted

@christopherstieler Hi Christopher, thank you very much for the words and for taking the time to comment, I really liked it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord