Any tips for improvement or constructive criticism are more than welcome! This is one of my first times using SASS, so if you could share any feedback about how I implemented it in this project, that would be fantastic.
I would appreciate help with the structure and functionality of my JavaScript code. I wrote it in a way that I believe might not be optimal, and any tips or constructive criticism that could help me improve my JavaScript code would be greatly appreciated.
Any tips for improvement or constructive criticism are welcome.
Any constructive criticism or tips for improvement are welcome and appreciated.
Any tips for improvement or constructive criticism are always welcome.
pude terminarlo pero puedo mejorar el codigo
What challenges did you encounter, and how did you overcome them?el ultimo bloque pensaba que era una tabla y me complique mucho pero despues encontre una solucion con los bordes
What specific areas of your project would you like help with?a simplificar un poco mas el codigo
Hola Jonathan, ¿cómo estás? Espero que bien. Después de revisar tu código y el preview, pude ver que pusiste mucho esfuerzo en tu trabajo y realmente hiciste un buen trabajo haciéndolo legible y fiel a la página. Solo quería mencionarte algunas cosas que noté y que podrían ayudarte. Observé que la tabla de abajo la hiciste con div y p tags, y creo que podrías haber logrado el mismo resultado con table, th y tr tags, haciendo así tu código más semántico y evitando la "divitis". También noté que solo realizaste la versión para celular y no utilizaste @media para crear las versiones de tablet y PC, lo que hace que la screenshot quede desubicada. Pero puedo ver que pusiste un gran esfuerzo en hacer tu código muy detallado y fiel a la versión original. Espero verte más por aquí, es bueno encontrar a otras personas que hablan español. ¡Hiciste un gran trabajo! Saludos.
semantic html, BEM naming convention, responsive design, dry css code
Hello DMVDEV, your design turned out great! It’s very faithful to the design we were given. After reviewing your code and comparing it to the design, here are my thoughts: for the alt attribute in the img tag, we don’t need to use camelCase; we can separate the words so the reader can easily understand what we’re conveying. Writing "profile picture" was a good choice as it’s a clear description of the image. The first div after main could be a section to better separate the content above from the content below and to avoid "divitis." When we have a list of buttons like this, using ul and li tags can help organize it. I really liked how tidy your CSS is; the only thing I would add is a hover effect on the buttons, as the original design included a green hover with a transition, which I noticed wasn’t implemented. I hope some of this feedback is helpful. You did a great job, and I hope to see more of your work here!
I used the table-layout amd boder-collaps properties, that's powerful. I'll change the color next time.
Hi Titw, I really liked your solution; it’s very close to the design we were given. If I had to suggest something for improvement, it would be paying more attention to the detail of the text color. You used black, but it’s actually a lighter shade. Also, in the mobile version, there’s still padding on the sides of the image. You can fix this by taking the image out of the main and treating it as a sibling of the main instead of a child. I hope you keep up the good work because you did a great job!
I learned how to do things on my own not look countless YOUTUBE videos which is a complete time wasting process.
What challenges did you encounter, and how did you overcome them?there were plenty of challenges alonge the way, so I did them one by one like google fonts and things like that.
What specific areas of your project would you like help with?I am not too sure about the code structures and naming the classes.
Hi Mohammad Nabi Ebrahimi,
First of all, I want to say that you’re doing a great job, and I can see you’re putting a lot of effort into your work! It’s wonderful to see how you’re progressing, and I hope my suggestions might be helpful in some way. 😊
I noticed a couple of areas where you could enhance your code further:
The semantics of your HTML could improve by using tags like <main> or <ul> directly, instead of adding them as class names. This will make your code more structured and accessible. For your CSS, I’d recommend relying mostly on classes for styling instead of ids. Using classes has several benefits, such as reusability and scalability. You can still use ids when you want a rule to specifically override others, which makes them even more effective. Another tip: consider using CSS variables for your colors. They make maintaining and tweaking your design much easier in the long run. You’re definitely on the right track, and I’m sure these small adjustments will only take your skills to the next level. Keep up the great work—I’m excited to see how you’ll continue to grow! 🌟
I'm most proud that this exercise was relatively simple to me given that I haven't worked with HTML and CSS in a long time. I would use a CSS framework next time.
What challenges did you encounter, and how did you overcome them?None.
What specific areas of your project would you like help with?I'm open to constructive criticism.
Hi jyoung0930,
I just wanted to say how incredibly impressed I am with your code—it’s truly well-crafted and shows great attention to detail! You’ve done an amazing job, and it’s inspiring to see such clean and organized work.
As a small constructive suggestion (and only if you think it’s worth considering), I noticed two things:
The top part of the QR image in your design seems slightly larger than the original design. Instead of using a <section> inside another <section>, you could use a <main> to wrap the component for a more semantic structure. Again, these are just minor points in an otherwise excellent piece of work. Fantastic job! 😊
Hi Jesus. Your design turned out really well. I saw that you even put your own ingenuity into decorating the profile photo with that border, how cool! I wanted to tell you a couple of things that could help you on your way to being better at the frontend, such as writing with html tags in a more semantic way. I saw that you used a div with a header class. The class is fine, but remember that you don't have to put a div on everything. This element could very well be a header tag. The different p elements that you put in could have been h1, h2, or others. I also wanted to point out that you didn't put an alt on the image. It's important that we get into the habit of adding it so that people who may have problems with the views can find it easier for them to navigate the web. I send you my regards and I hope to continue seeing more of your solutions here. Cheer up.
