Skip to content
Submitted over 1 year ago

QR code pc

Hassan-Habib•10
@Hassan-Habib
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • George Bleyer•280
    @georgebleyerPosted over 1 year ago

    Hello,

    Congratulations on completing this challenge. Here are some tips on how to align your card. In your body put this code:

    display:grid;
place-items:center;
min-height: 100vh;

    You can use Flex Grid to align the card to.

    I hope it helped.

    Marked as helpful
    0
  • Ecem Gokdogan•9,380
    @ecemgoPosted over 1 year ago

    Some recommendations regarding your code that could be of interest to you.

    HTML

    In order to fix the accessibility issues:

    • You need to replace <div class="attribution"> with the <main class="attribution"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
    • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you need to use a <h1> element in the <main> tag instead of using <h2>. You can replace your <h2>Improve your front-end skills by building projects</h2> element with the <h1>Improve your front-end skills by building projects</h1> element.
    • For the font-family to work correctly, add the following between the <head> tags in HTML file:
    <link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap" rel="stylesheet">

    CSS

    • If you want to center it easily, you can use flexbox in the body and if you want, you can give the recommended color to the background in this way:
    body {
  background-color: hsl(212, 45%, 89%);
  font-family: "Outfit", sans-serif;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
}
    • then, you don't need to use margin to .attribution. This .attribution is the updated version:
    .attribution{
  max-width: 320px;  // max-width makes the card responsive
  background-color: white;
  padding: 20px;
  border-radius: 5%;
}

    Hope I am helpful. :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord