@visualdenniss
Posted
Hello there,
your card looks pretty good. It is nice that you have already implemented the other suggestions about centering etc.
-
Additionally, i'd say try to avoid giving fixed heights like this: height: 497px; use only min-height when necessary, but most of the time you don't need any height. Height should be decided by the content of the container, if needed simply tweak it with paddings and margins of the contents. Fixed heights are known to cause various issues, resulting in overflowing content when data or font-sizes change.
-
Relatedly try to avoid using px, instead use the responsive rem/em units. Here is a great resource on YT for clarifying all the differences between rem/em and explain why to use them: https://www.youtube.com/watch?v=dHbYcAncAgQ
Hope you find this feedback helpful!
Marked as helpful
@avgrimshaw
Posted
Applied the suggested changes π
Thank you for the feedback and advice, it makes a lot of sense, also thanks for the informational YouTube link π