Lars Fredrik• 60
@LarsiParsii
Posted
It doesn't look bad at all, but there are some quick changes I would implement:
- Use the included "style-guide.md" file. It gives you the correct colors, font family/size, etc. Colors can also be extracted using a color picker.
- While your solution of adding the image as the background image of the "qrcode-box" div works, it would be clearer and more accessible if you added it directly to the HTML file, using the "<img>" tag.
- I think it would simplify your life if you, using the universal selector, *, set "box-sizing: border-box".
- If you set the height of the "container" div to fill the entirety of the viewport height using "height: 100vh", the card (or "general-box" in your code) would also be centered vertically. Always.
- The bottom corners of the card doesn't have rounded corners. ;)
0