QR code page , css ,html ,flexbox

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • If you want to make the card centered both horizontally and vertically, you'd better add flexbox and min-height: 100vh to the body
  • For the color of the screen, you can use the recommended color in the body

  body {
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
    /* background-color: hsl(211, 35%, 83%); */
    background-color: hsl(212, 45%, 89%);
  }
  

  • If you use flexbox in the body, you don't need to use flexbox in the .containor to center the card
  • If you use max-width instead of width and height, the card will be responsive
  • You'd better give padding to give a gap between the content and the border of the card
  • You can add the text-align: center here to center texts to avoid repetition

  .containor {
    /* height: 700px; */
    /* width: 500px; */
    max-width: 280px;
    /* background-color: aliceblue; */
    background-color: white;
    /* display: flex; */
    /* flex-wrap: wrap; */
    /* align-content: flex-start; */
    /* justify-content: center; */
    border-radius: 20px;
    padding: 15px;
    text-align: center;
  }
  

  • In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better add width: 100% for the img

  img {
    width: 100%;
    /* background-color: black; */
    /* width: 25em; */
    /* margin-top: 25px; */
    border-radius: 20px;
  }
  

  • You'd better reduce font-size of h2 a bit

  h2 {
    color: hsl(218, 44%, 22%);
    /* font-size: 30px; */
    font-size: 20px;
    /* text-align: center; */
  }
  

  • Finally, if you follow the steps above, the card will be responsive you can remove media queries and .bottom-section to avoid repetition

  /* .bottom-section {
    margin-left: 60px;
    margin-right: 60px;
    text-align: center;
  } */
  
  /* @media (max-width: 2000px) {
    body {
      display: flex;
      justify-content: center;
    }
  } */
  

  Hope I am helpful. :)

  Marked as helpful

  1

  ---

  

  Yuzuki9•20

  @Yuzuki9Posted over 1 year ago

  @ecemgo OMG this is so helpful thanks a lot I'll definitely try it

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @Yuzuki9 happy to help! :)

  1
• 

  Panji•2,090

  @pperdanaPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have some additional recommendations for your code that I think you'll find interesting and valuable.

  📌 Add <main> tag as semantic HTML in code

  • The <main> tag is a semantic HTML element that is used to define the main content of a web page.

  • The <main> tag should be used to wrap the primary content of a web page, such as the main article, section, or body of text.

  for example code:

  <main>
    <div class='container'>
      <h1>Article Title</h1>
      <p>Article content goes here...</p>
      .......................
    </div>
  </main>
  

  In the example above, the <main> tag is used to wrap the <div> tag, which contains the primary content of the web page. This tells both human readers and search engines that the content inside the <main> tag is the most important and relevant content on the page.

  I hope you found this helpful!

  Happy coding🤖

  1