Skip to content
Submitted over 2 years ago

QR Code

Michael Tze•480
@Biggboss7
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello Everyone, I've just completed this QR Code Challenge by Frontend Mentor. Please kindly give any feedbacks. Thankyou.

Community feedback

  • Karol Binkowski•1,640
    @GrzywNPosted over 2 years ago

    Hey @Biggboss7, well done 🙌

    The only thing which is not correct is a font color. Everything is almost pixel perfect 🥳

    I can suggest using full names instead of shortcuts. For example margin-left or padding-bottom instead of margin and padding. You can also try using more modern CSS properties which set margins / paddings for respectively left and right or top and bottom (margin-inline, padding-inline or margin-block and padding-block). It's the best if your code is written in a way, that nobody needs to think about what it does.

    Hope this helps! Have a nice day and keep coding!

    1
    Michael Tze•480
    @Biggboss7Posted over 2 years ago

    @GrzywN Thankyou so much on your feedback. Really appreciate it..

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord