QR code for desktop and mobile

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • In order to fix the accessibility issues, you need to replace <div class="QR-container"> with the <main> tag and <div class="attribution"> with the <footer> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

  • Also, each main content needs to start with an h1 element, and also contain only one h1 element. Your accessibility report states the need for one main landmark. So, you need to use a <h1> element in the <main> tag instead of using <h2>. You can replace your <h2>Improve your front-end skills by building projects</h2> elements with the <h1>Improve your front-end skills by building projects</h1> element.

  Hope I am helpful. :)

  Marked as helpful

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hello Fiorella,

  very nice work there, the final result looking pretty good. However there are few suggestions for improvement and best practices:

  • You don't to use height: 50%; avoid fixed heights, especially on text containing elements, as it can cause various problems, instead let the content determine the size of container. Use paddings/margins inside if necessary.

  • Using margins like margin: auto; margin-top: 100px; is not a good way to center it on the page. Might not work always. Instead use a more universal and stable approach:

  • All you need is min-height: 100vh; for the body to make it cover whole screen height, then use FLEXBOX or GRID, like display: grid; place-items: center;

  • Also using a css reset might help you solve many issues in advance. Here is a great resource: https://www.joshwcomeau.com/css/custom-css-reset/

  Hope you find this feedback helpful!

  Marked as helpful

  0