QR code components

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  IryDev•1,580

  @IryDevPosted over 1 year ago

  Cheer for completed your first challenge on frontend mentor challenge 😀 I hope it was useful to you and you have learned new things or have improved your skills

  I have few suggestions to improve your solution:

  This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage Put the main content of the website in the main tag in order to improve accessibility and organization of your page. HTML :

  <main>
   The main content of your website here
  </main>
  

  Hope you'll find this helpful, above all your solutions is really good !

  HAPPY CODING!

  Marked as helpful

  0