QR Code Component with html css

Community feedback

• 

  Aakash Verma•9,520

  @skyv26Posted about 2 months ago

  Hi @tobi-defeats-the-code 👋,

  Congratulations on achieving a near pixel-perfect design! 🎉 Your hard work and attention to detail are evident, and the project looks great. However, here are a few suggestions to further enhance your code quality and maintainability:

  1. Remove Commented Code
     🚫 Unnecessary commented-out code in the HTML can clutter the file and make it harder to read. Consider removing this snippet:

     <!--
       <div class="attribution">
         Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
         Coded by <a href="https://tobi-defeats-the-code.github.io/qr-code-component/">Tobias Marzyan</a>.
       </div>
     -->
     

     Keeping your code clean will make it more professional and easier to maintain.

  2. Separate Styles into a Dedicated CSS File
     🎨 It’s a good practice to move your inline or embedded styles into an external CSS file. This separation improves reusability, keeps your HTML clean, and aligns with industry best practices. It’ll also make it easier to update styles in the future.

  By making these tweaks, your project will not only shine visually but also adhere to coding best practices. Great job so far, and keep up the fantastic work! 🚀

  0

  ---

  

  P

  Tobias•30

  @tobi-defeats-the-codePosted about 2 months ago

  @skyv26
  You are of course right that a css file is stored in a separate file and I can take out the code for the comment. I was just lazy with a simple project, but I changed the code.

  1