QR Code Component using Vanilla HTML and CSS

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • If you use flexbox in the body, you don't need to use flexbox in the main to center the card because it doesn't work. You'd better try to avoid repetition.
  • If you use max-width instead of width, it makes the card responsive

  main {
    /* display: flex; */
    /* flex-direction: column; */
    /* justify-content: center; */
    /* width: 320px; */
    max-width: 320px;
  }
  

  • In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better add width: 100% and display: block for the img in this way:

  img {
    border-radius: 10px;
    width: 100%;
    display: block;
  }
  

  Hope I am helpful. :)

  Marked as helpful

  1
• 

  Panji•2,090

  @pperdanaPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have some additional recommendations for your code that I think you'll find interesting and valuable.

  📌 Add <footer> tag as semantic HTML in code

  • The <footer> tag is another semantic HTML element that is used to define the footer section of a web page.

  • The <footer> tag should be used to wrap the content that appears at the bottom of a web page, such as copyright notices, contact information, or links to other pages.

  for example code:

  <footer class="attribution">
    Challenge by <a href="https://www.frontendmentor.io?ref=challenge" 
    target="_blank">Frontend Mentor</a>. 
    .................................
  </footer>
  

  In the example above, the <footer> tag is used to wrap the copyright notice, which is the content that appears at the bottom of the web page. This tells both human readers and search engines that the content inside the <footer> tag is the footer section of the web page.

  I hope you found this helpful!

  Happy coding🤖

  Marked as helpful

  0