qr code component using html and css

Some recommendations regarding your code that could be of interest to you.

• If you want, I recommend Flexbox as an idea for this solution as well as Grid:
• In order to center the card correctly, you'd better add flexbox and min-height: 100vh to the body

body{
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
    /* min-width: 375px; */
}

• If you use flexbox in the body, you don't need to use margin in the .container to center the card
• If you use max-width instead of width, the card will be responsive.

.container {
  /* margin: 5% auto; */
  /* padding: 15px 0; */
  padding: 20px;
  /* width: 340px; */
  max-width: 340px;
}

• In order to make the card centered vertically, you can reduce the margin-top of the .attribution a bit:

.attribution {
  /* margin-top: 100px; */
  margin-top: 1rem;
}

Hope I am helpful. :)

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

• Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

• We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

• To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

• For this demonstration we use css Grid to center the component.

body {
    min-height: 100vh;
    display: grid;
    place-items: center;
}

• Now remove these styles, after removing you can able to see the changes

.container {
  margin: 5% auto;
}
.attribution {
  margin-top: 100px;
}

• Now your component has been properly centered

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!