QR Code Component using HTML and CSS

Community feedback

• 

  chamackstone•470

  @yannmarcPosted about 1 year ago

  Hello there! Great job on your solution! I'd like to provide some feedback to further enhance your work:

  HTML Semantics: Consider adding a description to your images using the alt attribute. This will not only improve the accessibility of your page but also provide alternative text for users who may have trouble viewing the images. You can use the syntax alt="alt text" to achieve this.

  Container Styling: Instead of using a fixed width for your container, I recommend using max-width: 250px to ensure that it remains within a reasonable size on smaller viewports. Additionally, setting width: 100% will make your container card more responsive, adapting well to different screen sizes.

  Body Section: To create some breathing space around the corners on smaller viewports, consider adding padding-inline: 24px to your body section. This will introduce a bit of white space and improve the overall visual appeal.

  Container Image: To ensure that the image within your container fits the width of its parent, you can apply width: 100% to the container img style. Additionally, adding margin-inline: auto will centre the image horizontally within the container.

  By implementing these suggestions, your solution will become even more polished and user-friendly. Keep up the great work! 🤓

  Marked as helpful

  0
• 

  ldonnianni•130

  @ldonnianniPosted about 1 year ago

  Thanks for your feedback I tried them all! I don't quite get Body Section: To create some breathing space around the corners on smaller viewports, consider adding padding-inline: 24px to your body section. This will introduce a bit of white space and improve the overall visual appeal.

  But I think is mostly because I don't understand entirely the workflow mobile-desktop.

  0