QR code component using HTML and CSS

Community feedback

• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 10 months ago

  Hello there 👋 @MercySitienei.

  Good job on completing the challenge !

  Your project looks really good!

  I have suggestions about your code that might interest you.

  Consider changing the background-color of the body element to hsl(212, 45%, 89%) then add the rest of the code to the body element of your project so as to centralize it.

  body {
    background-color: hsl(212, 45%, 89%);
    min-height: 100vh;
    justify-content: center;
    align-items: center;
  }
  
  

  Consider changing the color of the paragraph tag to hsl(220, 15%, 55%)

  p {
    color: hsl(220, 15%, 55%);
  }
  

  I hope it helps!

  Other than that, great job!

  Happy coding.

  Marked as helpful

  1

  ---

  

  MercySitienei•20

  @MercySitieneiPosted 10 months ago

  Thank you @Ezekiel225

  0
• 

  Covenant-0•100

  @Covenant-0Posted 10 months ago

  You did very well for your first project, however it still needs a few adjustments.

  1. The image is not centered in the desktop view
  2. For the background and text colors, check the styles guide for the correct color.
  3. Your body should have a main element.
  4. If possible indent your code properly so as to make it easier for others to read your code.
  5. As for the height, you can set the height of the body to 100vh

  Marked as helpful

  0

  ---

  

  MercySitienei•20

  @MercySitieneiPosted 10 months ago

  Thank you @Covenant-0

  0