Qr Code Component Challenge using HTML & CSS (FlexBox)

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • The text Improve Your Front-End Skills by Building Projects is considered a heading element.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS 🎨:

  • Setting a defined height for the card component is not recommended. The content should define the component height, otherwise, it will not be allowed to extend beyond your specifications.

    In desktop devices, your text overflows from the component: image screencapture-hanzala-bhutto-github-io-FlexBox-QR-Code-Component-FrontendMentor

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Hanzala Bhutto•260

  @hanzala-bhuttoPosted almost 2 years ago

  @MelvinAguilar ThankYou for the feedback

  Update: Followed @MelvinAguilar suggestion to let the content inside the qr-component defined the height and it worked like a charm. Content inside the component does not overflow any more.

  1