Design comparison
Community feedback
- @st0272Posted about 2 months ago
Your HTML and CSS code are mostly well-structured, but I have a few suggestions for overall design consistency.
-
While
section
is fine, consider using the<main>
element if it wraps the main content of the page. -
The current footer contains “Your Name Here,” which should be replaced with your actual name. Also, consider using a more semantic element like
<p>
instead of a<span>
for text content. -
Several elements such as
.card
,.flex
,img
,.heading
,.text
are using fixed pixel values, which could affect responsiveness on different devices and screen sizes. -
The screen size is currently fixed at a height of 1044px, which might not be responsive on smaller screens. You should try using
min-height: 100vh
; for.card
instead, which allows the height to adapt to the viewport. -
Using class names like
.container
for the outer wrapper and.card
for the actual card could indeed make the code more intuitive and easier to understand.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord