qr-code-component-main

Community feedback

• 

  P

  Øystein Håberg•10,490

  @Islandstone89Posted about 2 months ago

  Hi, good job. Here are some tips to further improve your solution!

  HTML:

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Change .footer from a <div> to a <footer>, and move it outside of <main>.

  • Wrap the footer text in a <p>.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Use the style guide to find the correct background-color and the correct font-family.

  • I would recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • You don't need to have margin: 0 on the body when it is already set on all elements using the universal selector *.

  • I would move font-family to body.

  • text-decoration: none could be set on links, but it doesn't make too much sense to set it on all elements since that is the default value of most elements.

  • On body, add flex-direction: column and gap: 2rem.

  • I would move the styles on main to the <div> that holds the card content - the main doesn't need any styles.

  • max-width on the card should be in rem. Around 20rem will work fine.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.

  Marked as helpful

  0