QR code component made with simple display flex and html

Community feedback

• 

  Nguyễn Đức Chính•310

  @chinh1402Posted about 1 year ago

  Well done on finishing the challenge, here are my takes on your solution

  1. Both description texts and headline texts are black, which gives a strong feeling when looking at it, therefore it just makes the headline feel.. not that interesting. Maybe you should follow the style-guide color pallets of the challenge
  2. The spacing between headline texts and description texts is too large, consider removing the gap in your text-div class; same goes with the spacing between your headline and the qr-image
  3. The image is unfortunately not centered, the part to the right of the image is bigger than the part to the left of the image.

  I'm not an expert, but my general opinion on this is.. This looks like a solution that was made in a hurry. Take your time, follow the style guide, and as a beginner, you should try to match the design as much as possible.

  Everyone has a starting point, hope to see more of your solutions in the future

  Marked as helpful

  2
• 

  Hudayfa•110

  @hdif004Posted about 1 year ago

  your code is good, you just have to change background color of you body and also import the font that it used on the design.

  Marked as helpful

  1

  ---

  

  Sudhir Bhargav•10

  @sudhirbhargavPosted about 1 year ago

  Thanks for the feedback, just edited the solution @hdif004

  0