QR Code Component - HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • The width: 100vw property for main element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• Account deleted

  Hello Coder 😊

  Your solution is great✨ and congratulations for successfully completing an another newbie challenge🎉

  and there is a small suggestion that might be helpful for you

  min-height :

  You can use min-height instead of height

  because height will put your element to a size of 100% of it's container. min-height will put the element to min 100% of the container size.

  if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space

  and it will helpful when you make responsive solutions

  Hope that was helpful 😊

  Marked as helpful

  1