QR code component

Community feedback

• 

  hitmorecode•6,270

  @hitmorecodePosted about 1 year ago

  Nice looks good. Here are a few recommendations

  • Make it a habit using css reset. If you don't know what that is, here is a simple css reset

  ## This will remove unnecessary empty spaces
  * {
    margin: 0;
    padding: 0;
    box-sizing: border-box;
  }
  

  • Make it a habit of always adding body on your css and always give it a min-height: 100vh;. This is important to make a page responsive to it's content.
  • Remove the background color from .main to body. If you add flexbox on the body, you'll place the card in the middle of the page.

  body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
    background-color: hsl(212, 45%, 89%);
  }
  

  • Remove margin-top:35px; on .main, flexbox on the body will do the same.
  • Change h2 to h1, because every page must have one h1.

  Don't see these as mistakes but as improvements 😁

  Marked as helpful

  3

  ---

  

  sumaira10041•210

  @sumaira10041Posted about 1 year ago

  Thnx alot. It's really informative for me. Thnx for ur guidence@hitmorecode

  0