Skip to content
Submitted over 1 year ago

QR Code Component Design

ashebani•400
@ashebani
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Bader Idris•2,880
    @Bader-IdrisPosted over 1 year ago

    You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

    .container {
  display: absolute;
  top:50%;
  left: 50%;
  transform: translate(-50%, -50%);
}

    the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

    Marked as helpful
    1
  • IryDev•1,580
    @IryDevPosted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should use semantics html to improve accessibility on your page :
    • put the main content of your page in the semantic <main> tag
    • Your page must have a <h1> tag which represents the main content of your page or a title
    • Replace the h2tag by the h1 tag

    HTML :

    <body>
   <main>
            The main content of your website
   </main>
</body>

    I also make a pull request on your Github repo so you can merge it if the changes suit you

    I hope you'll find this helpful, and your solutions is really good 😁

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord