Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component created in HTML and SCSS

Athiraā€¢ 130

@athirasarman

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi Everyone,

Here is my solution for QR Code Component done in HTML5 and SCSS. Feel free to go through my code and give suggestions for improving my code. Alternate solutions are also welcome.

Thanks in advance.

Community feedback

Shashree Samuelā€¢ 9,260

@shashreesamuel

Posted

Hey good job completing this challenge, however I have the following suggestions

  • The image is supposed to be contained within your card

  • The color of the card description does not match the color specified in the style-guide.md file

  • The card title is supposed to have a heavier font weight

In terms of your accessibility issues simply wrap all your content between main tags

I hope this helps

Cheers Happy coding šŸ‘

Marked as helpful

1

Athiraā€¢ 130

@athirasarman

Posted

@TheCoderGuru thank you!

0
Jeuri Morelā€¢ 1,405

@JeuriMorel

Posted

Hi @athirasarman, nicely done.

You have a few accessibility issues which should be quite easy to fix.

  • First, change the <div class="content"></div> to <main class="content"></main>. Remember that all page content should be contained by landmarks and that the page should have one main landmark.
  • Make the <p class="header-text"></p> an h1. Page should contain a level-one heading.

Marked as helpful

0

Athiraā€¢ 130

@athirasarman

Posted

@JeuriMorel thank you!

0
Hikmahā€¢ 1,070

@Hikmahx

Posted

Hi Athira. Great solution. I just want to suggest for a better user experience, I think you should darken the color of the paragraph text to something like color: #b8bbc0;. Also, instead of wrapping the header-text and content-text classes in a parent span tag, it's better to use a div tag. Doing so would remove the HTML issues on your app.

Marked as helpful

0

Athiraā€¢ 130

@athirasarman

Posted

@Hikmahx thank you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord