QR CODE COMPONENT

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Looks nice! To get rid of issues ake sure to use main tag instead of div (the one with class card) and use h1 for the text "Improve your front-end skills by building projects"

  Marked as helpful

  0
• 

  Joanna Skrzypczak•530

  @joaskrPosted almost 2 years ago

  Hi Tushar Pandey,

  good job with the challenge! It looks great.

  If you want to make it even better here are some suggestions:

  Accessibility

  • Wrap your content in a <main> tag instead of using a <div> -> <main class="container"> Using HTML landmark elements, such as <header> <nav> <main> <footer> improves accessibility of your site.
  • You can also replace <h2> with <h1>. Since this is the only header in the solution it fits better to use a <h1>. Also, it is a good practice to have one level one header on a website.

  Design

  • I noticed a small bug when you open the website on a mobile device in landscape mode - the content is too big for the screen and is only partially visible. You may want to look into that. 😊

  Overall good job 🎉

  Marked as helpful

  0