QR code component

Community feedback

• 

  Vitor Emanoel da Silva Nogueira•170

  @VitorEmanoelNogueiraPosted 4 months ago

  Hello, Baegan-189! Great work!

  After seeing your code, I have some modifications to suggest:

  • Studying and using semantic HTML. You can use for the main conteiner (which here contains the QR code and the texts), using the <main> tag. It's a good practice and it would help for using the padding on all the itens simutaneously and then just needing to do some ponctual changes for the rest;
  • Studying how to vertically align conteiners in the center. I would recomend you to look how to do it with the position and transform:translate properties first and, when you get a little more advanced, using flexbox, which is an easier alternative.

  I believe that with just these two tips your solution will be exactly like the design. Sorry if my feedback it's a little confusing, English is not my first language.

  Marked as helpful

  0

  ---

  

  Baegan-189•90

  @Baegan-189Posted 4 months ago

  @VitorEmanoelNogueira Thank you VitorEmanoelNogueira, for your tips and ill try to apply it.

  0