QR-Components

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="wrapper"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give the img a max-with of 100% instead of a width and height value.

  Give h1 the same font-size as <p> and give h1 and p the same margin-left, margin-right and margin-top values. Give p a margin-bottom value.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Harshana Lakmal•20

  @HarshanaLakmal98Posted almost 2 years ago

  @Hassiai Thank you very much! Your advice is really helpful for my journey.

  1
• 

  Tux3er•780

  @Tux3er-IsmaPosted almost 2 years ago

  Hi Harshana:

  Your code looks nice 🎉, congrats!

  There is some tips for your next project 💡:

  • Try to put the <br> tag in the correct position to try to get the same design as the model.

  • Also try to decorate more you Readme.md file to get some followers and talk to other programmers and get more experience.

  • I recomend you to use BEM css. This is an example of BEM css .my-container__my-text--blue so you can acces to an element and know what element it is with the class.

  That's all, i hope this tips help you in your next project 👍🏻!

  Marked as helpful

  0

  ---

  

  Harshana Lakmal•20

  @HarshanaLakmal98Posted almost 2 years ago

  @Tux3er-Isma Thanks for your valuable advice. and I am extremely grateful for reviewing my project. and next time I also pay attention to the README file.

  0