Joanna Skrzypczak• 530
@joaskr
Posted
Hi :) Good job with the solution! It looks just like the design! Here are some minor suggestions if you want to improve your code :)
Accessibility
- You should use HTML landmark elements such as <header><nav><main><footer> because they improve accessibility. In your code you can change
<section class="container">to<main class="container">
Visual aspect
- I noticed a small bug in your solution. When you open the site on mobile in landscape mode the design gets a little bit broken. You might want to look into that.
Code
- You are using px in your project. As per the responsive design best practices you should use rem and em. Here's a nice blog post explaining them.
Overall, great job! Let me know if you have any questions
Keep coding and good luck with future challenges!
Marked as helpful
1
