QR Code challenge

Community feedback

• 

  Mathanraj T•60

  @mathanraj0601Posted over 2 years ago

  Use "/" instead of "" and use " " instead of ' ' in the image tag hope it help :)

  Marked as helpful

  1

  ---

  

  darthTh0t•50

  @darthTh0tPosted over 2 years ago

  Hi @mathanraj0601, thank you for your valuable feedback. I will definitely implement it

  0
• 

  vcodey•270

  @v-codeyPosted over 2 years ago

  hey @arnav-sahoo, Good job on your first challenge. I saw your source code, there are few things I would like to add.

  • use main tag inside body For more info
  • naming your class root not recommended its a pseudo selector read more
  • use of br read more

  happy coding. 👍

  0

  ---

  

  T

  Grace•31,230

  @grace-snowPosted over 2 years ago

  @v-codey some of the answers on the stackoverflow about good use of br are not right. Always be careful pointing to that as a resource.

  Br used inside paragraphs to try and control where a line breaks is bad because it is read out to screenreader / text to speech users and breaks the flow of the writing. Better to use max width and let the text break where it needs to.

  Br used in place of margin is bad for similar reasons, and unnecessary when that's what margin is for

  I hope that's a clearer explanation

  1

  

  vcodey•270

  @v-codeyPosted over 2 years ago

  Hey @grace-snow ,

  I couldn't find any better resource at that time so I selected stackoverflow, will surely remember next time while providing resources.

  I knew br isn't recommended to be used for some issues but wasn't aware about the screen reader accessibility.

  thanks for your feedback

  1

  

  darthTh0t•50

  @darthTh0tPosted over 2 years ago

  Hi @v-codey and @grace-snow, thank you so much for your valuable feedback. I was able to learn a lot from the discussion and will definitely try to do better for future challenges.

  0