Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code challenge

Johnny V 10

@kernelpaniik

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

clickglue 120

@clickglue

Posted

Hi, your code looks like you've done this before. It's your 'initial solution' so you've done this in one go. I'm not very experienced, but I read in other feedback that you should not use px for font size, but rem instead.

0
DanniJK1 10

@DanniJK1

Posted

The solution includes semantic HTML. It's very accessible. It looks good on a range of screen sizes. The code is very well-structured and readable. The solution does not differ from the design at all. The only thing I can see that could be improved on is adding comments to the HTML for better readability. Otherwise, good job!

0
fr4nbtt 50

@fr4nbtt

Posted

Semantic HTML: It might be beneficial to use more semantic elements (e.g., <header>, <footer>, <section>) for enhanced accessibility.

Missing <h1>: It might be helpful to include an <h1> element for better document structure and SEO.

Accessibility: Adding ARIA labels for interactive elements may enhance support for screen readers.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord