QR code card made with using CSS basic properties

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • If you want to make the card centered both horizontally and vertically, you'd better add justify-content: center; to the body

  body {
    justify-content: center;
  }
  

  • If you use flexbox in the body, you don't need to use margin in the .wrapper to center the card
  • If you use max-width, the card will be responsive

  .wrapper {
    /* margin: 0 1em; */
    max-width: 300px;
  }
  

  • Finally, you don't need to use .container and you can remove it to clean the code

  /* 
  .container {
    max-width: 360px;
    margin: 0 auto;
  } 
  */
  

  Hope I am helpful. :)

  0

  ---

  

  Pranjali Pongde•90

  @pranjalipongdePosted about 1 year ago

  @ecemgo thank you for your suggestion. I would like to implement it and yes , learnt new way as well.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  .container {
    justify-content: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
    margin: 0 auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Pranjali Pongde•90

  @pranjalipongdePosted about 1 year ago

  @0xAbdulKhalid Thank you for explaining so well about sematic tags , i will keep in mind this things.

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted about 1 year ago

  @pranjalipongde Glad you found it helpful ! 🤠

  0