Design comparison
SolutionDesign
Community feedback
- @Djamel1133Posted 5 days ago
Great job, you're making excellent progress.
I noticed a few small issues that you might want to address:
- You're not pointing to the QRcode repository correctly (please check).
- For best practices, move any styling from your HTML file into your CSS file (best practice).
- The paragraph (
<p>
) text size seems to be off; it should be 12px instead of 2px (certainly an oversight). Also, consider usingrem
orem
units for consistency, like you did for other elements. - To center your container, use
margin: auto
instead ofmargin: 3rem auto
; this will center the card both horizontally and vertically, not just horizontally.
Keep up the good work and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord