Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Challenge, responsive card

Flori 10

@FloriMartin

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It was my first time at trying responsive desing. To be honest, I'm not quite sure how I made it worked. And I don't know why in the smallest resolution (using the dev tools of chrome) the image it's not in the middle. But it was fun anyways.

Community feedback

vcodey 270

@v-codey

Posted

hey @FloriMartin, Good job on your first challenge. I saw your code, there are few things I would like to mention

  • use main tag inside body see this solution for better understanding
  • instead of padding: 20px 20px 20px 20px - > padding: 20px will give same results. read more

happy coding.

Marked as helpful

1
Travolgi 🍕 31,420

@denielden

Posted

Hi Flori, I took some time to look at your solution and you did a great job!

Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all margin from recuadro class because with flex they are superfluous
  • use flexbox to the body for center the card
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

Overall you did well 😉

Hope this help and happy coding!

Marked as helpful

0

Flori 10

@FloriMartin

Posted

@denielden Thanks a lot!!

1

@Ahmed666313

Posted

Hello anyway, congratulations, you can use margin- top

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord