QR Challenge, responsive card

Community feedback

• 

  vcodey•270

  @v-codeyPosted over 2 years ago

  hey @FloriMartin, Good job on your first challenge. I saw your code, there are few things I would like to mention

  • use main tag inside body see this solution for better understanding
  • instead of padding: 20px 20px 20px 20px - > padding: 20px will give same results. read more

  happy coding.

  Marked as helpful

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Flori, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all margin from recuadro class because with flex they are superfluous
  • use flexbox to the body for center the card
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Flori•10

  @FloriMartinPosted over 2 years ago

  @denielden Thanks a lot!!

  1
• 

  AhmedAlasyotY•110

  @Ahmed666313Posted over 2 years ago

  Hello anyway, congratulations, you can use margin- top

  1