QR card

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code could be of interest to you.

  • In order to center the card easily and correctly, you'd better add flexbox and min-height: 100vh to the body

  body {
     display: flex;
     justify-content: center;
     align-items: center;
     min-height: 100vh;
  }
  

  • After adding them, you can remove margin-top and display: inline-block from the .card because you don't need them anymore

  .card {
     /* display: inline-block; */
     /* margin-top: 150px; */
  }
  

  Hope I am helpful. :)

  0

  ---

  

  jsr7k•20

  @jsr7kPosted over 1 year ago

  @ecemgo Thank you so much for your recomendations they were very helpful. I'll apply them tonight.

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @jsr7k happy to help :)

  0
• 

  skopelosbill•40

  @skopelosbillPosted over 1 year ago

  Well done jsr7k, like you I have just done this as my very first and did a similar job. I am also an older newbie. I am still trying to figure out the centring part of it, but I think you did well.

  Skopelosbill

  0
• 

  Anthony•10

  @crossant123Posted over 1 year ago

  Good Job for a first.

  However the size is off, if you center the design vertically it makes it easier to compare the sizes. If you redo this challenge, I think you'll nail it!

  0