Pure HTML and CSS, writen on VS CODE | CSS GRID

Community feedback

• 

  huzaifanur•110

  @huzaifanurPosted about 3 years ago

  Nice work. Try making it responsive

  Marked as helpful

  0

  ---

  

  wallyson Ruan•130

  @wallysonruanPosted about 3 years ago

  @huzaifanur

  I'm gonna do it soon. Responsiveness calls for "non-fixed" sizes, right? I'm already working on that – by that I mean studying – :D

  0
• 

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  Hi Wallyson,

  Could elaborate more on that one?

  Marked as helpful

  0

  ---

  

  wallyson Ruan•130

  @wallysonruanPosted about 3 years ago

  @fidellim

  Elaborate my question? If so, look at the bottom border of the image, you'll see that the card goes beyond the image limits.

  0

  

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  @wallysonruan I am sorry but I still couldn't visualize it. I was looking at your project and it looks alright. However, you could add media queries later on once you have learn it :)

  0
• 

  Gia Phong•80

  @giaphong992Posted about 3 years ago

  Hey bro, great work here. But I notice that you use fixed unit like px too much, so I think you should change and try to use the relative unit. For the problem, it can be solved by using 100% height in img tag and h tag which can remove the line off the limits of the image. Cheers mate, great work though.

  Marked as helpful

  0

  ---

  

  wallyson Ruan•130

  @wallysonruanPosted about 3 years ago

  @giaphong992

  Thanks for that! I'll soon try that solution! -

  About the fixed unit, that's because I just started studying it – not even a month has passed since then. So I'm still trying to figure out how they work, I thought It'd better if I, first, tried to create a layout really basic just to understand it all a bit more, then I'd jump to relative units.

  0