Design comparison
SolutionDesign
Solution retrospective
Hello everyone,
Any advice on how I could improve this or make my code easier to read.
Any help would be appreciated. Thank you in advance.
Community feedback
- @dusanlukic404Posted about 3 years ago
Hey Daniel, nice work! I have a few suggestions for you:
- Attribution should be outside the main card so I think it would be great if you put it inside footer element
- Also, for image element in alternative atribute you shouldn't have words like image, picture ect.
Overall, the solution looks great and matches the design 100% but take a look on your accessibility and HTML issues.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord