Skip to content
Submitted almost 3 years ago

Profile card component

Ahmed Besheer•90
@ahmedbesheer
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

First time using BEM for naming classes while learning SASS.

and is my background-position the SVG patterns for the body element efficient or is there a better and simple approach?

any suggestions or feedback would be appreciated :)

Community feedback

  • Ediongsenyene Joseph I.•1,675
    @IEdiongPosted almost 3 years ago

    Great job on completing this challenge. You could try looking into the accessibility and HTML issues raised here.

    Shalom!

    Marked as helpful
    1
    Ahmed Besheer•90
    @ahmedbesheerPosted almost 3 years ago

    @IEdiong Thanks for your words :), I'll look into the issues and update the solution with a clean one.

    but I just wondering if you know a solution for the Accessibility issue rather than using the H1 element instead of H3.

    because it doesn't make sense to use H1 in a small component like this.

    0
    Ediongsenyene Joseph I.•1,675
    @IEdiongPosted almost 3 years ago

    @ahmedbesheer You could do some research into .sr-only (screen readers only). This should fix it for you.

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord