Design comparison
Solution retrospective
Any suggestions on improving the code would be appreciated!
Community feedback
- @FluffyKasPosted about 3 years ago
Hey, your solution looks good! The only thing seems to be missing is vertical centering. I saw you tried doing it with flexbox on the
body
but foralign-items: center
to work you'll need a height. Try addingmin-height:
100vh`, that should fix it. I'd also remove the alt-text "pattern", there's no need for it, as it's just decoration ^^ Otherwise well done :)Marked as helpful1@nntt1210Posted about 3 years ago@FluffyKas Thank you for your feedback! I will work on it.
0 - @fidellimPosted about 3 years ago
Hi Tmnguyen!
Great work on the project! I would say there isn't much to improve on your code. It looks well made already. You even implemented BEM methodology for your classes. You might want to start focusing on learning some JavaScript. Well done :)
1@nntt1210Posted about 3 years ago@fidellim Thank you for your feedback! I will start learning JavaScript soon!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord