Submitted over 3 years ago
Profile Card built using Html and CSS (Bootstrap)
@letyoursoulglo
Design comparison
SolutionDesign
Solution retrospective
Any feedback is greatly appreciated. With being a beginner I'm not quite sure what I should ask.
Community feedback
- @dewslysePosted over 3 years ago
Hello Antonius 👋! Congrats on completing your first challenge. Good job overall 👍
A few things to note
- Your card is not vertically centered on the page and skews up as one reduces window size. You can add
display: flex
andmin-height: 100vh
to yourbody
to center the card. - Line 23 of your html is missing the closing
>
for the link<link rel="stylesheet" href="css/styles.css" </head>
- Your
footer
tag should be in thebody
- You may also want to use sectioning or landmark elements within your html. You could wrap your the main/dominant content of your page within the
<main>
tag. This will resolve some of the accessibility issues.
I hope you find these helpful.
All the best
Marked as helpful1 - Your card is not vertically centered on the page and skews up as one reduces window size. You can add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord