Produtc Preview Card

Community feedback

• 

  Stanchuks•50

  @Ebussraph25Posted about 2 years ago

  OK thanks What about the container class? is it ok . Then I notice that in the mobile display of this project it seems to have a gap in between the image and the price cart box. what could be the problem

  Marked as helpful

  1
• 

  Bizzare•1,320

  @godmayhem7Posted about 2 years ago

  wow your challenge solution was nice your challenge was totally fine but you kinda overlooked certain thing on your end instead of using section-tag as the main tag in the body section you should have just used main instead and also you should have used a button-tag = <button></button> to make your add to cart button instead of using divs and anchor tags and also in your style make sure to use body{ height : num vh} that is to create a professional gap from the top of your window how this feedback was really helpful

  Marked as helpful

  1

  ---

  

  Nayara Freitas•40

  @NayaraFreitasPosted about 2 years ago

  @godmayhem7 Thanks for your suggestions . I will following them . Thank you so much

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the Main Element.

  • The image’s “Alt Tag” description needs to be improved upon to better describe what they is. You will want to assume that you are describing the image to a someone.

  • This component requires the use of two images 🎑 at different breakpoints. The Picture Element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a Paragraph Element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a Del Element and inside it you will add a Span Element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  1

  ---

  

  Nayara Freitas•40

  @NayaraFreitasPosted about 2 years ago

  @vcarames Thanks to take your time and give me some suggestions , I really appreciate that, I will following them. Thank you so much

  0