Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Produtc Preview Card

@NayaraFreitas

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Esse challenge foi feito só com html e css , pois não possuo conhecimento de um framework de css ainda , ainda preciso praticar bastante o css , esse preview está sem a responsividade pois ainda não tenho um conhecimento concreto sobre essa parte. Estarei estudando para melhorar e aprimorar meus conhecimentos

Community feedback

Stanchuks 50

@Ebussraph25

Posted

OK thanks What about the container class? is it ok . Then I notice that in the mobile display of this project it seems to have a gap in between the image and the price cart box. what could be the problem

Marked as helpful

1
Bizzare 1,320

@godmayhem7

Posted

wow your challenge solution was nice your challenge was totally fine but you kinda overlooked certain thing on your end instead of using section-tag as the main tag in the body section you should have just used main instead and also you should have used a button-tag = <button></button> to make your add to cart button instead of using divs and anchor tags and also in your style make sure to use body{ height : num vh} that is to create a professional gap from the top of your window how this feedback was really helpful

Marked as helpful

1

@NayaraFreitas

Posted

@godmayhem7 Thanks for your suggestions . I will following them . Thank you so much

0

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the Main Element.

  • The image’s “Alt Tag” description needs to be improved upon to better describe what they is. You will want to assume that you are describing the image to a someone.

  • This component requires the use of two images 🎑 at different breakpoints. The Picture Element will facilitate this.

Here is an example of how it works: EXAMPLE

Syntax:

  <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

More Info:

https://www.w3schools.com/html/html_images_picture.asp

https://web.dev/learn/design/picture-element/

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a Paragraph Element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a Del Element and inside it you will add a Span Element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🍂🦃

Marked as helpful

1

@NayaraFreitas

Posted

@vcarames Thanks to take your time and give me some suggestions , I really appreciate that, I will following them. Thank you so much

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord