Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Review Card

Uzair Bajwaโ€ข 40

@bajwacodes

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


The hardest thing for me was making it responsive for mobile & desktop with media queries.

I also struggled to center it right in the middle of the page with flexbox, it just centers horizontally, but vertically, nothing changes even if I use align-content & align-items.

Community feedback

Pranshu Sahuโ€ข 770

@Pranshu-Sahu

Posted

โœจ Hello @bajwacodes, congratulations ๐ŸŽ‰ for your solution!

You component structure ๐Ÿงจ is really good done, you need only to give it more styling, note that in the starter files there is a file called styleguide.md that has all info you need to give it styling, for example the paragraph sizes, the heading, colors and etc.

If you don't mind, I have few suggestions-

    display: flex;
    margin: 0;
    min-height: 100vh;
    align-items: center;
    justify-content: center;
} ``` 

** Above code will center   main  horizontally and vertically. **
 
If you have need further help feel free to leave comment. ๐Ÿ‘จโ€๐Ÿ’ป


Hope it helps and happy coding!๐Ÿ™‚
1
Lucas ๐Ÿ‘พโ€ข 104,420

@correlucas

Posted

๐Ÿ‘พHello @bajwacodes, Congratulations on completing this challenge!

Your solution its almost done and Iโ€™ve some tips to help you to improve it:

Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isnโ€™t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

See the example below:

<picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

๐Ÿ‘จโ€๐Ÿ’ปHere's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-dVGWpOTgWS

โœŒ๏ธ I hope this helps you and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord