Design comparison
SolutionDesign
Community feedback
- @webdevbynightPosted 3 months ago
Some feedback:
- the repository of your solution is not available;
- when using
h1
toh6
, make sure the hierarchy between level headings is relevant and avoid using ah4
before ah1
, for example; - on mobile and on Safari, the rounded corners of the image do not appear (maybe a bug, because they appear on Firefox and Chrome);
- on desktop and on Safari, the way you use flexbox makes vertical margins too high compared to the design (maybe a bug, because on Firefox and Chrome, the margins are as expected);
- when testing your front-end development, test your CSS on several browsers to make sure no bugs are left, including on Safari (if possible);
- when defining font sizes, you should avoid doing it in pixels (like on line 75 of your stylesheet) : here is a video explaining why.
I hope this feedback helps you.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord