Product Preview Card using SCSS and Flex

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted about 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  POINTING CURSOR ↗️:

  • Looks like the component's button element has not a pointer, this property plays a major-role in terms of both UI & UX

  ---

  • The cursor: pointer CSS property is important for button-like elements because it changes the cursor from the default arrow to a pointer when hovering over the element. This provides a visual cue to the user that the element is clickable and encourages interaction.

  ---

  • In terms of UI/UX, using cursor: pointer helps to improve the usability of the interface by making it easier for users to identify interactive elements. It also helps to provide feedback to the user by indicating which elements are clickable and which are not.

  ---

  • So we want to add this property to the following button element

  .product-card__info-btn {
     cursor: pointer;
  }
  

  • Now your component's button has got the pointer & you learned about this property as well

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  ldonnianni•130

  @ldonnianniPosted about 1 year ago

  Thanks @0xAbdulKhalid I completly forgot about it!

  0
• 

  adonisloyd•510

  @adonisloydPosted about 1 year ago

  perfect! Your design looks exactly like the example.

  0
• 

  solitary_coder•1,000

  @kabir-afkPosted about 1 year ago

  The reason you had to put your images in dist folder is because your index.html is inside that folder.

  Look , whenever you deploy a webpage through gh-pages , it first scans your repo for an index.html file , but since your index.html was in dist folder you had to change the abs paths for other urls as well like for images . . .try to keep your index.html seperately , that way all the files will be globally available, and your repo would be easy to deploy

  <picture class="product-card__image">
                <source media="(min-width: 600px)" srcset="
              images/image-product-desktop.jpg">
  
              <source srcset="
              images/image-product-mobile.jpg">
  
              <img src="images/image-product-desktop.jpg" alt="perfume-Gabrielle">
          </picture>
  

  your index was inside dist and images were outside , due to which the images weren't accessible , since urls work in heirarchial order. . . if both of them were independent file/folders , you would have constructed url in the same way you did here

  0

  ---

  

  ldonnianni•130

  @ldonnianniPosted about 1 year ago

  Hi @kabir-afk , I understand that putting the index.html in the dist folder and deploying from there is changing my abs paths. What I don't know how to do is working with scss (which create the dist/css folder). If I put my index outside the dist folder it won't recognize my css. thanks.

  0

  

  solitary_coder•1,000

  @kabir-afkPosted about 1 year ago

  @ldonnianni well then you can change the abs path of the css file in your index.html, with something like

  <link rel = "stylesheet" href="dist/styles.css"> 
  

  since your scss file and generated output css file are in dist folder , by changing their abs paths like mentioned above will make them accessible .

  Marked as helpful

  0

  

  ldonnianni•130

  @ldonnianniPosted about 1 year ago

  Thanks @kabir-afk I'll try that.

  0