Product preview card component using HTML/CSS
Design comparison
Community feedback
- @godmayhem7Posted almost 2 years ago
heyy @imenehaissam your code was amazing πππ,here are some tips on how to better your code ; i noticed in your code the background didn't cover the entire page this is because you didn't set the background for the body, you should have done it like this (body{background:hsl(30, 38%, 92%)}) and also wrapping your entire code just all around div-tags looks kinda messy don't you think try using other interactive tags together with div-tags to make a clean and understandable code like main-tag(<main></main>), nav-tag(<nav></nav>),header-tag(<header></header>),section-tags(<section></section>) and footer-tag(<footer></footer>) these tags are self explanatory and also they make your code cleaner and more understandable. the rest of your code was okayππ . hope this feedback was helpfulππ
0@imenehaissamPosted almost 2 years ago@godmayhem7 Thank you for your help. Providing me with this valuable feedback, I will take this point in considration to improve my code nchallah.^^
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord