Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here is some feedback to further improve your code:

  • The image’s alt tag description needs to be improved upon ⚠️. Assume that you are describing the image to someone over the phone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints ⚠️. The picture element will facilitate this.

  Here is how it looks like implemented: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a s element and inside it you will add a span element with an visually-hidden class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  The Strikethrough Element

  • Change ⚠️ the height to min-height in your body element, to improve your component's responsiveness and remove the width: 100vw; as is not needed.

  • ALWAYS Implement a "Mobile First" approach 📱 > 🖥

  Mobile devices are now the dominant 👑 way in which people browse the web. So when building your content, you will start building with small screen sizes (starting at 320px) and work your way to larger screens using min-width.

  More Info: 📚

  Mobile First

  If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  1

  ---

  

  Munsif Ali•200

  @Munsif-AliPosted almost 2 years ago

  @vcarames Thank you so much for your valuable feedback. I will definitely checkout the resource you mentioned and still i am learning how to make good design i will be more than happy if you give me good resources for that.

  I want to ask one question your product preview card is different you make it by yourself or this is other challenge?

  Thank you so much.

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @Munsif-Ali

  Glad I could help!

  It is the same challenges as yours, I just modified it.

  0