@Thewatcher13
Posted
HTML
- There should be always a main landmark element in your html for semantics reasons
- NEVER skip the headings order in the html, you can't have an h2 before you have an h1!
- Make sure that your image has an alt atribute (important!) (like already said, you should use the picture elemnt)
- Use for the OLD price the S-tag in html
- Be sure you know the different between a button and a link (the button here should be a link)
CSS
- WORK MOBILE-FIRST NOT DESKTOP/TABLET (media queries hould be used for desktop or tablet!)
- You should have in every project a css reset (look at Andy's Bell website for a clea and good one)
- Your font-size should never be in (absolute values) px but in rem (relative value) https://fedmentor.dev/posts/font-size-px/
- Don't-set a height on a container, the content provides the height
Marked as helpful
@Aziztheprogrammer
Posted
@Thewatcher13 Thanks A Lot For Your Feedback Bro ! I Made Some Improvement To The Project Like Adding A CSS Reset File And Adding A Main Semantic Element But Concerning The Height I Will To Avoid Doing That Again In The Future And Thank You Again.