Product Preview Card Component - Responsive Design

Community feedback

• 

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  HTML

  • There should be always a main landmark element in your html for semantics reasons
  • NEVER skip the headings order in the html, you can't have an h2 before you have an h1!
  • Make sure that your image has an alt atribute (important!) (like already said, you should use the picture elemnt)
  • Use for the OLD price the S-tag in html
  • Be sure you know the different between a button and a link (the button here should be a link)

  CSS

  • WORK MOBILE-FIRST NOT DESKTOP/TABLET (media queries hould be used for desktop or tablet!)
  • You should have in every project a css reset (look at Andy's Bell website for a clea and good one)
  • Your font-size should never be in (absolute values) px but in rem (relative value) https://fedmentor.dev/posts/font-size-px/
  • Don't-set a height on a container, the content provides the height

  Marked as helpful

  0

  ---

  

  Aziz Berhouma•330

  @AziztheprogrammerPosted over 1 year ago

  @Thewatcher13 Thanks A Lot For Your Feedback Bro ! I Made Some Improvement To The Project Like Adding A CSS Reset File And Adding A Main Semantic Element But Concerning The Height I Will To Avoid Doing That Again In The Future And Thank You Again.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Aziz Berhouma•330

  @AziztheprogrammerPosted over 1 year ago

  @0xAbdulKhalid I Appreciate Your Effort To Help Me Bro ! So In The Future I'll Try To Avoid This Mistake And To Use The <Picture> Element. And Thanks Again !

  0
• 

  hitmorecode•6,680

  @hitmorecodePosted over 1 year ago

  Well done congratulations. There's two things that you can fix.

  • On mobile the image container has three border radius. Remove the left bottom radius.
  • On mobile there is a lot of empty space in the bottom of the card

  Marked as helpful

  0

  ---

  

  Aziz Berhouma•330

  @AziztheprogrammerPosted over 1 year ago

  @hitmorecode Thank You Bro For Your Feedback !

  0