Product Preview Card Component made with Flex box and Media Queries

Community feedback

• 

  romila•3,570

  @romila2003Posted over 2 years ago

  Hi @AlanLopRey,

  Welcome to frontendmentor.io and congratulations 🎉 for completing your first project. It was a good attempt.

  When reviewing your code and design, I did notice some issues.

  1. There are many HTML issues that can be addressed. For example, you forgot to give your img element a self-closing tag therefore you received an error regarding this. Most of the issues regarding your HTML was based on the fact that you wrapped your text into the span element instead of div's or other tags. Spans are not used correctly in your code.
  2. It is best practice to wrap your whole code in a main tag as this is semantically correct e.g. <main class="container"></main>.
  3. You can also wrap your footer in a footer tag too e.g. `<footer class="attribute"></footer>
  4. You should remove the border with your button e.g. border: none;

  Other than some HTML issues, your CSS looks great and wish you the best of luck with future projects. Keep coding 👍.

  Marked as helpful

  0
• 

  Enmanuel Otero Montano•2,155

  @Enmanuel-Otero-MontanoPosted over 2 years ago

  ¡Hola Alan! Felicidades por completar el desafío.

  Un pequeño feedback para ti:

  Yo sustituiría el <div class="cardContainer"> por una etiqueta main y lo mismo haría con este 👉 <div class="textContainer">, pero en este caso lo sustituiría con una etiqueta section. Todo esto para escribir código lo más semantico posible y brindar una mejor experiencia de usuario en cuanto a accesibilidad.

  Saludos🦾🦾🦾

  Marked as helpful

  0