Design comparison
SolutionDesign
Community feedback
- @lack21Posted over 1 year ago
Good job 👍, but I have some recommendations!
- Remove
width: 100vw
from thebody
,body
is a block level element which by default takes full width available, sowidth: 100vw
does nothing here! - Replace
height: 100vh
tomin-height: 100vh
in thebody
, the difference is that, when you setheight: 100vh
to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to setmin-height: 100vh
, like this in case content is overflowing container will adjust to it, after that you can as well removeheight: auto
from thebody
!
Marked as helpful0 - Remove
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord