Product Preview Card Component Challenge

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has been centered properly. But the issue is the content inside the body causes overflow on smaller screens and let people scroll the content, this issue want to be cleared because we don't need to use margin here it's just causing overflow issues.

  ---

  • Now remove these margin from body, after removing you can able to see the changes

  body {
    margin: 1rem;
  }
  

  ---

  ---

  • Now the overflow of content has been cleared

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1
• 

  IryDev•1,580

  @IryDevPosted over 1 year ago

  Hey well done for completed this challenge😁

  I have some suggestions to help you to improve your solution :

  • You should put the <div class="attribution"> outside the <main> tag
  • then replace the <div> tag by semantic tag <footer>
  • footer can contain informations about author, copyright etc

  HTML :

  <main>
  </main>
  
  <footer class="attribution">
  </footer>
  

  I also make pull requests on your Github repo so you can merge it if the changes suit you

  I hope you'll find this helpful, and your solutions is really good 😁

  0